fix(cluster): guard substring slice + redact join credentials in logs#654
Merged
ArangoGutierrez merged 1 commit intoNVIDIA:mainfrom Feb 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request addresses two audit findings related to the cluster provisioning code:
- HIGH severity: Prevents a potential panic when slicing
CACertHashif the openssl output is truncated - MEDIUM severity: Redacts sensitive join credentials (bootstrap token and certificate key) from log output
Changes:
- Added length guard before substring slicing to prevent panic on short CA cert hash
- Redacted bootstrap token from logs (changed from plaintext to [REDACTED])
- Redacted certificate key from logs (removed the partial display)
Pull Request Test Coverage Report for Build 21963025628Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CACertHash[:32]to prevent panic on truncated openssl outputAudit Findings
Changes
pkg/provisioner/cluster.go: Length guard + log redaction for join credentialsTest plan
gofmt— no formatting issuesgo build— compilesgo test ./pkg/...— all tests pass